These inline implementations of AV_COPY64, AV_SWAP64 and AV_ZERO64 are known to clobber the FPU state - which has to be restored with the 'emms' instruction afterwards. This was known and signaled with the FF_COPY_SWAP_ZERO_USES_MMX define, which calling code seems to have been supposed to check, in order to call emms_c() after using them. See 0b1972d4096df5879038f0af776f87f41e90ebd4, 29c4c0886d143790fcbeddbe40a23dfc6f56345c and df215e575850e41b19aeb1fd99e53372a6b3d537 for history on earlier fixes in the same area. However, new code can use these AV_*64() macros without knowing about the need to call emms_c(). Just get rid of these dangerous inline assembly snippets; this doesn't make any difference for 64 bit architectures anyway. Signed-off-by: Martin Storsjö <martin@martin.st>
		
			
				
	
	
		
			64 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			64 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2010 Alexander Strange <astrange@ithinksw.com>
 | |
|  *
 | |
|  * This file is part of FFmpeg.
 | |
|  *
 | |
|  * FFmpeg is free software; you can redistribute it and/or
 | |
|  * modify it under the terms of the GNU Lesser General Public
 | |
|  * License as published by the Free Software Foundation; either
 | |
|  * version 2.1 of the License, or (at your option) any later version.
 | |
|  *
 | |
|  * FFmpeg is distributed in the hope that it will be useful,
 | |
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 | |
|  * Lesser General Public License for more details.
 | |
|  *
 | |
|  * You should have received a copy of the GNU Lesser General Public
 | |
|  * License along with FFmpeg; if not, write to the Free Software
 | |
|  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 | |
|  */
 | |
| 
 | |
| #ifndef AVUTIL_X86_INTREADWRITE_H
 | |
| #define AVUTIL_X86_INTREADWRITE_H
 | |
| 
 | |
| #include <stdint.h>
 | |
| #include "config.h"
 | |
| #include "libavutil/attributes.h"
 | |
| 
 | |
| #if HAVE_MMX
 | |
| 
 | |
| #ifdef __SSE__
 | |
| 
 | |
| #define AV_COPY128 AV_COPY128
 | |
| static av_always_inline void AV_COPY128(void *d, const void *s)
 | |
| {
 | |
|     struct v {uint64_t v[2];};
 | |
| 
 | |
|     __asm__("movaps   %1, %%xmm0  \n\t"
 | |
|             "movaps   %%xmm0, %0  \n\t"
 | |
|             : "=m"(*(struct v*)d)
 | |
|             : "m" (*(const struct v*)s)
 | |
|             : "xmm0");
 | |
| }
 | |
| 
 | |
| #endif /* __SSE__ */
 | |
| 
 | |
| #ifdef __SSE2__
 | |
| 
 | |
| #define AV_ZERO128 AV_ZERO128
 | |
| static av_always_inline void AV_ZERO128(void *d)
 | |
| {
 | |
|     struct v {uint64_t v[2];};
 | |
| 
 | |
|     __asm__("pxor %%xmm0, %%xmm0  \n\t"
 | |
|             "movdqa   %%xmm0, %0  \n\t"
 | |
|             : "=m"(*(struct v*)d)
 | |
|             :: "xmm0");
 | |
| }
 | |
| 
 | |
| #endif /* __SSE2__ */
 | |
| 
 | |
| #endif /* HAVE_MMX */
 | |
| 
 | |
| #endif /* AVUTIL_X86_INTREADWRITE_H */
 |