ddf6ca3a0e
Add overflow test for hevc_add_res when int16_t coeff = -32768.
The result of C is good, while ASM is not.
To verify:
make fate-checkasm-hevc_add_res
ffmpeg/tests/checkasm/checkasm --test=hevc_add_res
./checkasm --test=hevc_add_res
checkasm: using random seed 679391863
MMXEXT:
hevc_add_res_4x4_8_mmxext (hevc_add_res.c:69)
- hevc_add_res.add_residual [FAILED]
SSE2:
hevc_add_res_8x8_8_sse2 (hevc_add_res.c:69)
hevc_add_res_16x16_8_sse2 (hevc_add_res.c:69)
hevc_add_res_32x32_8_sse2 (hevc_add_res.c:69)
- hevc_add_res.add_residual [FAILED]
AVX:
hevc_add_res_8x8_8_avx (hevc_add_res.c:69)
hevc_add_res_16x16_8_avx (hevc_add_res.c:69)
hevc_add_res_32x32_8_avx (hevc_add_res.c:69)
- hevc_add_res.add_residual [FAILED]
AVX2:
hevc_add_res_32x32_8_avx2 (hevc_add_res.c:69)
- hevc_add_res.add_residual [FAILED]
checkasm: 8 of 14 tests have failed
Signed-off-by: Xu Guangxin <guangxin.xu@intel.com>
Signed-off-by: Linjie Fu <linjie.fu@intel.com>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
97 lines
3.0 KiB
C
97 lines
3.0 KiB
C
/*
|
|
* Copyright (c) 2016 Alexandra Hájková
|
|
*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with FFmpeg; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include <string.h>
|
|
|
|
#include "libavutil/intreadwrite.h"
|
|
|
|
#include "libavcodec/hevcdsp.h"
|
|
|
|
#include "checkasm.h"
|
|
|
|
#define randomize_buffers(buf, size) \
|
|
do { \
|
|
int j; \
|
|
for (j = 0; j < size; j++) { \
|
|
int16_t r = rnd(); \
|
|
AV_WN16A(buf + j, r >> 3); \
|
|
} \
|
|
} while (0)
|
|
|
|
#define randomize_buffers2(buf, size) \
|
|
do { \
|
|
int j; \
|
|
for (j = 0; j < size; j++) \
|
|
AV_WN16A(buf + j * 2, rnd() & 0x3FF); \
|
|
} while (0)
|
|
|
|
static void compare_add_res(int size, ptrdiff_t stride, int overflow_test)
|
|
{
|
|
LOCAL_ALIGNED_32(int16_t, res0, [32 * 32]);
|
|
LOCAL_ALIGNED_32(int16_t, res1, [32 * 32]);
|
|
LOCAL_ALIGNED_32(uint8_t, dst0, [32 * 32 * 2]);
|
|
LOCAL_ALIGNED_32(uint8_t, dst1, [32 * 32 * 2]);
|
|
|
|
declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *res, ptrdiff_t stride);
|
|
|
|
randomize_buffers(res0, size);
|
|
randomize_buffers2(dst0, size);
|
|
if (overflow_test)
|
|
res0[0] = 0x8000;
|
|
memcpy(res1, res0, sizeof(*res0) * size);
|
|
memcpy(dst1, dst0, sizeof(int16_t) * size);
|
|
|
|
call_ref(dst0, res0, stride);
|
|
call_new(dst1, res1, stride);
|
|
if (memcmp(dst0, dst1, size))
|
|
fail();
|
|
bench_new(dst1, res1, stride);
|
|
}
|
|
|
|
static void check_add_res(HEVCDSPContext h, int bit_depth)
|
|
{
|
|
int i;
|
|
|
|
for (i = 2; i <= 5; i++) {
|
|
int block_size = 1 << i;
|
|
int size = block_size * block_size;
|
|
ptrdiff_t stride = block_size << (bit_depth > 8);
|
|
|
|
if (check_func(h.add_residual[i - 2], "hevc_add_res_%dx%d_%d", block_size, block_size, bit_depth)) {
|
|
compare_add_res(size, stride, 0);
|
|
// overflow test for res = -32768
|
|
compare_add_res(size, stride, 1);
|
|
}
|
|
}
|
|
}
|
|
|
|
void checkasm_check_hevc_add_res(void)
|
|
{
|
|
int bit_depth;
|
|
|
|
for (bit_depth = 8; bit_depth <= 10; bit_depth++) {
|
|
HEVCDSPContext h;
|
|
|
|
ff_hevc_dsp_init(&h, bit_depth);
|
|
check_add_res(h, bit_depth);
|
|
}
|
|
report("add_residual");
|
|
}
|