Go to file

Nicolas George a8ab52fae7 lavfi/vf_libvmaf: convert to framesync2.

After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:

src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int,  void *)’ but argument is of type ‘int (*)(float *, float *, float *, int,  double *, void *)’

==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116==    at 0x526D432: cons_ (ocval.h:1188)
==12116==    by 0x526D432: GenericIT (ocval.h:1119)
==12116==    by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116==    by 0x5211F5D: loads (pickleloader.h:566)
==12116==    by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116==    by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116==    by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116==    by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116==    by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116==    by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116==    by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116==    by 0x7967493: start_thread (pthread_create.c:333)
==12116==    by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116==    at 0x526D432: cons_ (ocval.h:1188)
==12116==    by 0x526D432: GenericIT (ocval.h:1119)
==12116==    by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116==    by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116==    by 0x5211F5D: loads (pickleloader.h:566)
==12116==    by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116==    by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116==    by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116==    by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116==    by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116==    by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116==    by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116==    by 0x7967493: start_thread (pthread_create.c:333)
==12116==    by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116==    at 0x526D432: cons_ (ocval.h:1188)
==12116==    by 0x526D432: GenericIT (ocval.h:1119)
==12116==    by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116==    by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116==    by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116==    by 0x5211F5D: loads (pickleloader.h:566)
==12116==    by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116==    by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116==    by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116==    by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116==    by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116==    by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116==    by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116==    by 0x7967493: start_thread (pthread_create.c:333)
==12116==    by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116==    at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116==    by 0x52AB5E8: combo (combo.c:149)
==12116==    by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116==    by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116==    by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116==    by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116==    by 0x7967493: start_thread (pthread_create.c:333)
==12116==    by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116==    at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116==    by 0x52AB5E8: combo (combo.c:149)
==12116==    by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116==    by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116==    by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116==    by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116==    by 0x7967493: start_thread (pthread_create.c:333)
==12116==    by 0x7F69A8E: clone (clone.S:97)
==12116==  Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116==  Access not within mapped region at address 0x40
==12116==    at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116==    by 0x52AB5E8: combo (combo.c:149)
==12116==    by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116==    by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116==    by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116==    by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116==    by 0x7967493: start_thread (pthread_create.c:333)
==12116==    by 0x7F69A8E: clone (clone.S:97)

2017-08-29 10:19:04 +02:00

compat

win32_dlfcn: Support WinRT/UWP.

2017-07-30 14:30:43 +10:00

doc

avformat/hls: Fix DoS due to infinite loop

2017-08-27 19:19:00 +02:00

ffbuild

build: Allow generating dependencies as a side-effect of assembling

2017-06-21 17:00:29 -03:00

libavcodec

avcodec/snowenc: fix setting motion_est option

2017-08-28 21:27:01 -03:00

libavdevice

lavd: implement NewTek NDI input/output device support

2017-08-27 18:07:50 +02:00

libavfilter

lavfi/vf_libvmaf: convert to framesync2.

2017-08-29 10:19:04 +02:00

libavformat

lavf/dump: Remove superfluous cast.

2017-08-29 01:33:47 +02:00

libavresample

build: Generalize yasm/nasm-related variable names

2017-06-21 17:00:29 -03:00

libavutil

libavutil/opencl: fix potential null dereference

2017-08-27 21:08:17 +02:00

libpostproc

Merge commit '92db5083077a8b0f8e1050507671b456fd155125'

2017-05-04 19:59:30 -03:00

libswresample

swresample/resample: Fix flush refelction length

2017-08-16 00:54:17 +02:00

libswscale

utils: Do not expand a macro with 'defined' in it

2017-08-25 13:44:57 +01:00

presets

…

tests

ffmpeg options: Enable trailing ? for map_channel

2017-08-25 23:41:11 +02:00

tools

build: Generalize yasm/nasm-related variable names

2017-06-21 17:00:29 -03:00

.gitattributes

fate: add SCC test

2017-01-27 17:06:42 +01:00

.gitignore

build: add support for building .cu files via nvcc

2017-05-15 11:46:50 +02:00

.travis.yml

build: Prefer NASM assembler over YASM

2017-06-21 17:00:30 -03:00

Changelog

lavd: implement NewTek NDI input/output device support

2017-08-27 18:07:50 +02:00

cmdutils_opencl.c

cmdutils_opencl: Fix read of uinitialized cl_mem

2017-05-11 13:02:12 +02:00

cmdutils.c

avformat, ffmpeg: deprecate old rotation API

2017-03-27 13:20:27 +02:00

cmdutils.h

Merge commit '122de16dd8108a59a55d30543c9f28b5f61b02d1'

2017-05-05 14:04:30 +02:00

configure

lavd: implement NewTek NDI input/output device support

2017-08-27 18:07:50 +02:00

CONTRIBUTING.md

Add CONTRIBUTING.md

2016-09-18 10:02:13 +01:00

COPYING.GPLv2

…

COPYING.GPLv3

…

COPYING.LGPLv2.1

…

COPYING.LGPLv3

…

CREDITS

…

ffmpeg_cuvid.c

ffmpeg_cuvid: adapt for recent filter graph initialization changes

2017-03-03 08:45:43 +01:00

ffmpeg_filter.c

ffmpeg: Support setting the hardware device to use when filtering

2017-06-14 22:27:07 +01:00

ffmpeg_hw.c

avconv_hw: Free device on initialisation failure

2017-06-18 17:07:25 +01:00

ffmpeg_opt.c

ffmpeg options: Enable trailing ? for map_channel

2017-08-25 23:41:11 +02:00

ffmpeg_qsv.c

ffmpeg: init filtergraphs only after we have a frame on each input

2017-03-03 08:45:43 +01:00

ffmpeg_videotoolbox.c

ffmpeg_videotoolbox: fix usage of av_get_codec_tag_string()

2017-03-29 14:49:29 +02:00

ffmpeg.c

avcodec: add missing FF_API_DEBUG_MV wrappers

2017-08-25 13:44:52 -03:00

ffmpeg.h

dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-06-27 18:05:02 +02:00

ffplay.c

ffplay: add support for more SDL pixel formats when rendering video

2017-08-10 22:08:40 +02:00

ffprobe.c

ffprobe: Fix NULL pointer handling in color parameter printing

2017-08-24 11:41:00 +02:00

ffserver_config.c

ffserver_config: Check for failure to allocate FFServerIPAddressACL

2016-12-22 19:23:08 +01:00

ffserver_config.h

ffsrever: Make the status page bitexact if any stream is bitexact

2016-11-29 19:26:26 +01:00

ffserver.c

Merge commit '122de16dd8108a59a55d30543c9f28b5f61b02d1'

2017-05-05 14:04:30 +02:00

INSTALL.md

…

LICENSE.md

Merge commit '4fef648d10bf3bcfd4b8fa5755c1128966a2427c'

2017-03-15 22:07:47 +01:00

MAINTAINERS

Add myself as speedhq maintainer, per request.

2017-08-03 16:36:02 -03:00

Makefile

dxva: add support for new dxva2 and d3d11 hwaccel APIs

2017-06-27 18:05:02 +02:00

README.md

Add CONTRIBUTING.md

2016-09-18 10:02:13 +01:00

RELEASE

Bump minor versions for master after release/3.3 branchpoint

2017-03-31 13:21:06 +02:00

README.md

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

libavcodec provides implementation of a wider range of codecs.
libavformat implements streaming protocols, container formats and basic I/O access.
libavutil includes hashers, decompressors and miscellaneous utility functions.
libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
libavdevice provides an abstraction to access capture and playback devices.
libswresample implements audio mixing and resampling routines.
libswscale implements color conversion and scaling routines.

Tools

ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
ffplay is a minimalistic multimedia player.
ffprobe is a simple analysis tool to inspect multimedia content.
ffserver is a multimedia streaming server for live broadcasts.
Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.

Languages

C 90.6%

Assembly 7.5%

Makefile 1.3%

C++ 0.2%

Objective-C 0.1%

Other 0.1%