Up until now, an AVFilter's lists of input and output AVFilterPads were terminated by a sentinel and the only way to get the length of these lists was by using avfilter_pad_count(). This has two drawbacks: first, sizeof(AVFilterPad) is not negligible (i.e. 64B on 64bit systems); second, getting the size involves a function call instead of just reading the data. This commit therefore changes this. The sentinels are removed and new private fields nb_inputs and nb_outputs are added to AVFilter that contain the number of elements of the respective AVFilterPad array. Given that AVFilter.(in|out)puts are the only arrays of zero-terminated AVFilterPads an API user has access to (AVFilterContext.(in|out)put_pads are not zero-terminated and they already have a size field) the argument to avfilter_pad_count() is always one of these lists, so it just has to find the filter the list belongs to and read said number. This is slower than before, but a replacement function that just reads the internal numbers that users are expected to switch to will be added soon; and furthermore, avfilter_pad_count() is probably never called in hot loops anyway. This saves about 49KiB from the binary; notice that these sentinels are not in .bss despite being zeroed: they are in .data.rel.ro due to the non-sentinels. Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
		
			
				
	
	
		
			89 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			89 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * This file is part of FFmpeg.
 | |
|  *
 | |
|  * FFmpeg is free software; you can redistribute it and/or
 | |
|  * modify it under the terms of the GNU Lesser General Public
 | |
|  * License as published by the Free Software Foundation; either
 | |
|  * version 2.1 of the License, or (at your option) any later version.
 | |
|  *
 | |
|  * FFmpeg is distributed in the hope that it will be useful,
 | |
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 | |
|  * Lesser General Public License for more details.
 | |
|  *
 | |
|  * You should have received a copy of the GNU Lesser General Public
 | |
|  * License along with FFmpeg; if not, write to the Free Software
 | |
|  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 | |
|  */
 | |
| 
 | |
| /**
 | |
|  * @file
 | |
|  * copy video filter
 | |
|  */
 | |
| 
 | |
| #include "libavutil/imgutils.h"
 | |
| #include "libavutil/internal.h"
 | |
| #include "avfilter.h"
 | |
| #include "internal.h"
 | |
| #include "video.h"
 | |
| 
 | |
| static int query_formats(AVFilterContext *ctx)
 | |
| {
 | |
|     AVFilterFormats *formats = NULL;
 | |
|     int ret;
 | |
| 
 | |
|     ret = ff_formats_pixdesc_filter(&formats, 0,
 | |
|                                     AV_PIX_FMT_FLAG_HWACCEL);
 | |
|     if (ret < 0)
 | |
|         return ret;
 | |
|     return ff_set_common_formats(ctx, formats);
 | |
| }
 | |
| 
 | |
| static int filter_frame(AVFilterLink *inlink, AVFrame *in)
 | |
| {
 | |
|     AVFilterLink *outlink = inlink->dst->outputs[0];
 | |
|     AVFrame *out = ff_get_video_buffer(outlink, in->width, in->height);
 | |
|     int ret;
 | |
| 
 | |
|     if (!out) {
 | |
|         ret = AVERROR(ENOMEM);
 | |
|         goto fail;
 | |
|     }
 | |
| 
 | |
|     ret = av_frame_copy_props(out, in);
 | |
|     if (ret < 0)
 | |
|         goto fail;
 | |
|     ret = av_frame_copy(out, in);
 | |
|     if (ret < 0)
 | |
|         goto fail;
 | |
|     av_frame_free(&in);
 | |
|     return ff_filter_frame(outlink, out);
 | |
| fail:
 | |
|     av_frame_free(&in);
 | |
|     av_frame_free(&out);
 | |
|     return ret;
 | |
| }
 | |
| 
 | |
| static const AVFilterPad avfilter_vf_copy_inputs[] = {
 | |
|     {
 | |
|         .name         = "default",
 | |
|         .type         = AVMEDIA_TYPE_VIDEO,
 | |
|         .filter_frame = filter_frame,
 | |
|     },
 | |
| };
 | |
| 
 | |
| static const AVFilterPad avfilter_vf_copy_outputs[] = {
 | |
|     {
 | |
|         .name = "default",
 | |
|         .type = AVMEDIA_TYPE_VIDEO,
 | |
|     },
 | |
| };
 | |
| 
 | |
| const AVFilter ff_vf_copy = {
 | |
|     .name        = "copy",
 | |
|     .description = NULL_IF_CONFIG_SMALL("Copy the input video unchanged to the output."),
 | |
|     FILTER_INPUTS(avfilter_vf_copy_inputs),
 | |
|     FILTER_OUTPUTS(avfilter_vf_copy_outputs),
 | |
|     .query_formats = query_formats,
 | |
| };
 |