AVMediaCodecDeviceContext without surface or native_window is useless, it shouldn't be created at all. Such dummy AVHWDeviceContext is allowed before, and it's used by mpv player. Creating a ANativeWindow automatically breaks such usecases. So disable creating a ANativeWindow by default. It can be enabled via the create_window flag, or by set the AVDictionary of av_hwdevice_ctx_create(). The downside is that ffmpeg -hwaccel mediacodec -i input.mp4 \ -c:a copy -c:v hevc_mediacodec output.mp4 use ByteBuffer mode which isn't as efficient as before. The upside is libavfilter works now, which should be less surprise. To enable create_window on ffmpeg command line, use ffmpeg -hwaccel mediacodec \ -init_hw_device mediacodec=mediacodec,create_window=1 \ -i input.mp4 -c:a copy -c:v hevc_mediacodec output.mp4 Users should know what it is to enable create_window. It should be OK to take sometime to figure out the option. And there are comments inside hwcontext_mediacodec.h to help user figure it out. Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
		
			
				
	
	
		
			122 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			122 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * This file is part of FFmpeg.
 | |
|  *
 | |
|  * FFmpeg is free software; you can redistribute it and/or
 | |
|  * modify it under the terms of the GNU Lesser General Public
 | |
|  * License as published by the Free Software Foundation; either
 | |
|  * version 2.1 of the License, or (at your option) any later version.
 | |
|  *
 | |
|  * FFmpeg is distributed in the hope that it will be useful,
 | |
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 | |
|  * Lesser General Public License for more details.
 | |
|  *
 | |
|  * You should have received a copy of the GNU Lesser General Public
 | |
|  * License along with FFmpeg; if not, write to the Free Software
 | |
|  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 | |
|  */
 | |
| 
 | |
| #include "config.h"
 | |
| 
 | |
| #include <android/native_window.h>
 | |
| #include <dlfcn.h>
 | |
| #include <media/NdkMediaCodec.h>
 | |
| 
 | |
| #include "buffer.h"
 | |
| #include "common.h"
 | |
| #include "hwcontext.h"
 | |
| #include "hwcontext_internal.h"
 | |
| #include "hwcontext_mediacodec.h"
 | |
| 
 | |
| typedef struct MediaCodecDeviceContext {
 | |
|     AVMediaCodecDeviceContext ctx;
 | |
| 
 | |
|     void *libmedia;
 | |
|     media_status_t (*create_surface)(ANativeWindow **surface);
 | |
| } MediaCodecDeviceContext;
 | |
| 
 | |
| 
 | |
| static int mc_device_create(AVHWDeviceContext *ctx, const char *device,
 | |
|                             AVDictionary *opts, int flags)
 | |
| {
 | |
|     const AVDictionaryEntry *entry = NULL;
 | |
|     MediaCodecDeviceContext *s = ctx->hwctx;
 | |
|     AVMediaCodecDeviceContext *dev = &s->ctx;
 | |
| 
 | |
|     if (device && device[0]) {
 | |
|         av_log(ctx, AV_LOG_ERROR, "Device selection unsupported.\n");
 | |
|         return AVERROR_UNKNOWN;
 | |
|     }
 | |
| 
 | |
|     while ((entry = av_dict_iterate(opts, entry))) {
 | |
|         if (!strcmp(entry->key, "create_window"))
 | |
|             dev->create_window = atoi(entry->value);
 | |
|     }
 | |
| 
 | |
|     av_log(ctx, AV_LOG_DEBUG, "%s createPersistentInputSurface\n",
 | |
|             dev->create_window ? "Enable" : "Disable");
 | |
| 
 | |
|     return 0;
 | |
| }
 | |
| 
 | |
| static int mc_device_init(AVHWDeviceContext *ctx)
 | |
| {
 | |
|     MediaCodecDeviceContext *s = ctx->hwctx;
 | |
|     AVMediaCodecDeviceContext *dev = (AVMediaCodecDeviceContext *)s;
 | |
|     ANativeWindow *native_window = NULL;
 | |
| 
 | |
|     if (dev->surface)
 | |
|         return 0;
 | |
| 
 | |
|     if (dev->native_window)
 | |
|         return 0;
 | |
| 
 | |
|     // For backward compatibility, don't return error for a dummy
 | |
|     // AVHWDeviceContext without surface or native_window.
 | |
|     if (!dev->create_window)
 | |
|         return 0;
 | |
| 
 | |
|     s->libmedia = dlopen("libmediandk.so", RTLD_NOW);
 | |
|     if (!s->libmedia)
 | |
|         return AVERROR_UNKNOWN;
 | |
| 
 | |
|     s->create_surface = dlsym(s->libmedia, "AMediaCodec_createPersistentInputSurface");
 | |
|     if (!s->create_surface)
 | |
|         return AVERROR_UNKNOWN;
 | |
| 
 | |
|     s->create_surface(&native_window);
 | |
|     dev->native_window = native_window;
 | |
|     return 0;
 | |
| }
 | |
| 
 | |
| static void mc_device_uninit(AVHWDeviceContext *ctx)
 | |
| {
 | |
|     MediaCodecDeviceContext *s = ctx->hwctx;
 | |
|     AVMediaCodecDeviceContext *dev = ctx->hwctx;
 | |
|     if (!s->libmedia)
 | |
|         return;
 | |
| 
 | |
|     if (dev->native_window) {
 | |
|         ANativeWindow_release(dev->native_window);
 | |
|         dev->native_window = NULL;
 | |
|     }
 | |
|     dlclose(s->libmedia);
 | |
|     s->libmedia = NULL;
 | |
| }
 | |
| 
 | |
| const HWContextType ff_hwcontext_type_mediacodec = {
 | |
|     .type                 = AV_HWDEVICE_TYPE_MEDIACODEC,
 | |
|     .name                 = "mediacodec",
 | |
| 
 | |
|     .device_hwctx_size    = sizeof(MediaCodecDeviceContext),
 | |
| 
 | |
|     .device_create        = mc_device_create,
 | |
|     .device_init          = mc_device_init,
 | |
|     .device_uninit        = mc_device_uninit,
 | |
| 
 | |
|     .pix_fmts = (const enum AVPixelFormat[]){
 | |
|         AV_PIX_FMT_MEDIACODEC,
 | |
|         AV_PIX_FMT_NONE
 | |
|     },
 | |
| };
 |