avcodec/ac3enc_float, eac3enc: Fix leaks on init error
The AC-3 encoders (both floating- as well as fixed-point) as well as the EAC-3 encoder share code: All use ff_ac3_encode_init() as well as ff_ac3_encode_close(). Until ee726e777b851cdd4e28cdab36b38f0c39e35ea9 ff_ac3_encode_init() called ff_ac3_encode_close() to clean up on error. Said commit removed this and instead set the FF_CODEC_CAP_INIT_CLEANUP flag; but it did the latter only for the fixed-point AC-3 encoder and not for the other two users of ff_ac3_encode_init(). This caused any already allocated buffer to leak upon a subsequent error for the two other encoders. This commit fixes this by adding the FF_CODEC_CAP_INIT_CLEANUP flag to the other two encoders using ff_ac3_encode_init(). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
This commit is contained in:
		
							parent
							
								
									ae36fad624
								
							
						
					
					
						commit
						f4e6aa609d
					
				@ -153,4 +153,5 @@ AVCodec ff_ac3_encoder = {
 | 
			
		||||
    .supported_samplerates = ff_ac3_sample_rate_tab,
 | 
			
		||||
    .channel_layouts = ff_ac3_channel_layouts,
 | 
			
		||||
    .defaults        = ac3_defaults,
 | 
			
		||||
    .caps_internal   = FF_CODEC_CAP_INIT_CLEANUP,
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
@ -266,4 +266,5 @@ AVCodec ff_eac3_encoder = {
 | 
			
		||||
    .supported_samplerates = ff_ac3_sample_rate_tab,
 | 
			
		||||
    .channel_layouts = ff_ac3_channel_layouts,
 | 
			
		||||
    .defaults        = ac3_defaults,
 | 
			
		||||
    .caps_internal   = FF_CODEC_CAP_INIT_CLEANUP,
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user