har0ke/FFmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avformat/mov: Fix incorrect overflow detection in mov_read_sidx()

Browse Source 
Fixes: signed integer overflow: 9223372036854775807 + 1442840321 cannot be represented in type 'long'
Fixes: 33670/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6644379491106816

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 200406d930eff3202f3230f188f85f4ab9cf4525)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2021-04-28 16:53:52 +02:00
parent 890a801468
commit da9e84fabd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavformat/mov.c
View File

@ -5132,7 +5132,7 @@ static int mov_read_sidx(MOVContext *c, AVIOContext *pb, MOVAtom atom)
if (frag_stream_info) if (frag_stream_info)
frag_stream_info->sidx_pts = timestamp; frag_stream_info->sidx_pts = timestamp;
if (av_sat_add64(offset, size) != offset + size || if (av_sat_add64(offset, size) != offset + (uint64_t)size ||
av_sat_add64(pts, duration) != pts + (uint64_t)duration av_sat_add64(pts, duration) != pts + (uint64_t)duration
) )
return AVERROR_INVALIDDATA; return AVERROR_INVALIDDATA;