har0ke/FFmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avcodec/avpacket: deprecate av_copy_packet_side_data()

Browse Source 
It leaks memory and destroys the dst packet in case of failure, and it
ultimately duplicates functionality already existing in the saner
av_packet_copy_props().

Reviewed-by: wm4
Signed-off-by: James Almer <jamrial@gmail.com>
This commit is contained in:
James Almer 2017-09-25 17:17:12 -03:00
parent fd5f4ac081
commit cf3d2d52b5
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libavcodec/avcodec.h
View File

@ -4632,7 +4632,10 @@ int av_copy_packet(AVPacket *dst, const AVPacket *src);
* Copy packet side data * Copy packet side data
* *
* @return 0 on success, negative AVERROR on fail * @return 0 on success, negative AVERROR on fail
*
* @deprecated Use av_packet_copy_props
*/ */
attribute_deprecated
int av_copy_packet_side_data(AVPacket *dst, const AVPacket *src); int av_copy_packet_side_data(AVPacket *dst, const AVPacket *src);
/** /**