har0ke/FFmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aarch64/hevc: Replace br return with ret

Browse Source 
This patch changes the return instruction in the tr_32x4 macro from
BR to RET.

Function returns should always use the RET instruction instead of BR,
to avoid interfering with branch prediction.

On devices that support BTI, this is observeable as a landing pad is
required when branching with BR. The change fixes
fate-hevc-hdr-vivid-metadata when on hardware with BTI support.

Signed-off-by: Casey Smalley <casey.smalley@arm.com>
Signed-off-by: Martin Storsjö <martin@martin.st>
This commit is contained in:
Casey Smalley 2023-07-27 11:26:26 +01:00 committed by Martin Storsjö
parent 418c954e31
commit b98ee1a355
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/aarch64/hevcdsp_idct_neon.S
View File

@ -790,7 +790,7 @@ function func_tr_32x4_\name
add x3, x11, #(32 + 3 * 64)
scale_store \shift
br x10
ret x10
endfunc
.endm