har0ke/FFmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avcodec/x86/dct32: Remove obsolete SSE function

Browse Source 
The only systems which benefit from ff_dct32_float_sse are truely
ancient 32bit x86s as all other systems use at least the SSE2 versions
(this includes all x64 cpus (which is why this code is restricted
to x86-32)).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt 2022-06-14 20:26:16 +02:00
parent 25e39f8c72
commit 54784ffac5
2 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libavcodec/x86/dct32.asm
View File

@ -387,7 +387,7 @@ INIT_XMM
%endif %endif
; void ff_dct32_float_sse(FFTSample *out, const FFTSample *in) ; void ff_dct32_float(FFTSample *out, const FFTSample *in)
%macro DCT32_FUNC 0 %macro DCT32_FUNC 0
cglobal dct32_float, 2, 3, 16, out, in, tmp cglobal dct32_float, 2, 3, 16, out, in, tmp
; pass 1 ; pass 1
@ -474,18 +474,8 @@ cglobal dct32_float, 2, 3, 16, out, in, tmp
%endmacro %endmacro
%macro LOAD_INV 2 %macro LOAD_INV 2
%if cpuflag(sse2)
pshufd %1, %2, 0x1b pshufd %1, %2, 0x1b
%elif cpuflag(sse)
movaps %1, %2
shufps %1, %1, 0x1b
%endif
%endmacro %endmacro
%if ARCH_X86_32
INIT_XMM sse
DCT32_FUNC
%endif
INIT_XMM sse2 INIT_XMM sse2
DCT32_FUNC DCT32_FUNC

5
libavcodec/x86/dct_init.c
View File

@ -22,7 +22,6 @@
#include "libavutil/x86/cpu.h" #include "libavutil/x86/cpu.h"
#include "libavcodec/dct.h" #include "libavcodec/dct.h"
void ff_dct32_float_sse(FFTSample *out, const FFTSample *in);
void ff_dct32_float_sse2(FFTSample *out, const FFTSample *in); void ff_dct32_float_sse2(FFTSample *out, const FFTSample *in);
void ff_dct32_float_avx(FFTSample *out, const FFTSample *in); void ff_dct32_float_avx(FFTSample *out, const FFTSample *in);
@ -30,10 +29,6 @@ av_cold void ff_dct_init_x86(DCTContext *s)
{ {
int cpu_flags = av_get_cpu_flags(); int cpu_flags = av_get_cpu_flags();
#if ARCH_X86_32
if (EXTERNAL_SSE(cpu_flags))
s->dct32 = ff_dct32_float_sse;
#endif
if (EXTERNAL_SSE2(cpu_flags)) if (EXTERNAL_SSE2(cpu_flags))
s->dct32 = ff_dct32_float_sse2; s->dct32 = ff_dct32_float_sse2;
if (EXTERNAL_AVX_FAST(cpu_flags)) if (EXTERNAL_AVX_FAST(cpu_flags))