har0ke/FFmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avcodec/mdec: DC reading for STRv1 is like STRv2

Browse Source 
As I understand, support for .STR files is broken for almost 10 years now (since 161442ff2c4b0dd8a5072c6bbe6bf55303fffccf it seems).

Currently, ffmpeg fails with tons of errors like this on version 1 STRs, e.g. Wipeout 1:
[mdec @ 00000000027c72c0] ac-tex damaged at 1 9

What happens is that only the audio is present in the video file.

Anyway, that one character patch fixes the problem, video is now rendered.

Signed-off-by: aybe <aybe@users.noreply.github.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
aybe aybe 2024-01-02 02:49:26 +00:00 committed by Michael Niedermayer
parent e664f4465a
commit 36b402f80d
No known key found for this signature in database
GPG Key ID: B18E8928B3948D64
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/mdec.c
View File

@ -68,7 +68,7 @@ static inline int mdec_decode_block_intra(MDECContext *a, int16_t *block, int n)
const int qscale = a->qscale; const int qscale = a->qscale;
/* DC coefficient */ /* DC coefficient */
if (a->version == 2) { if (a->version <= 2) {
block[0] = 2 * get_sbits(&a->gb, 10) + 1024; block[0] = 2 * get_sbits(&a->gb, 10) + 1024;
} else { } else {
component = (n <= 3 ? 0 : n - 4 + 1); component = (n <= 3 ? 0 : n - 4 + 1);