har0ke/FFmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avformat: refactor avformat_write_header

Browse Source 
Split away option settings, sanity checks and general setup.
This commit is contained in:
Luca Barbato 2012-10-01 00:49:18 +02:00
parent 86bbdf865e
commit 1e46c63eb7
1 changed files with 39 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
libavformat/mux.c
View File

@ -135,7 +135,8 @@ static int validate_codec_tag(AVFormatContext *s, AVStream *st)
return 1; return 1;
} }
int avformat_write_header(AVFormatContext *s, AVDictionary **options)
static int init_muxer(AVFormatContext *s, AVDictionary **options)
{ {
int ret = 0, i; int ret = 0, i;
AVStream *st; AVStream *st;
@ -248,12 +249,23 @@ int avformat_write_header(AVFormatContext *s, AVDictionary **options)
av_dict_set(&s->metadata, "encoder", LIBAVFORMAT_IDENT, 0); av_dict_set(&s->metadata, "encoder", LIBAVFORMAT_IDENT, 0);
} }
if (s->oformat->write_header) { if (options) {
ret = s->oformat->write_header(s); av_dict_free(options);
if (ret < 0) *options = tmp;
goto fail;
} }
return 0;
fail:
av_dict_free(&tmp);
return ret;
}
static int init_pts(AVFormatContext *s)
{
int i;
AVStream *st;
/* init PTS generation */ /* init PTS generation */
for (i = 0; i < s->nb_streams; i++) { for (i = 0; i < s->nb_streams; i++) {
int64_t den = AV_NOPTS_VALUE; int64_t den = AV_NOPTS_VALUE;
@ -270,22 +282,33 @@ int avformat_write_header(AVFormatContext *s, AVDictionary **options)
break; break;
} }
if (den != AV_NOPTS_VALUE) { if (den != AV_NOPTS_VALUE) {
if (den <= 0) { if (den <= 0)
ret = AVERROR_INVALIDDATA; return AVERROR_INVALIDDATA;
goto fail;
}
frac_init(&st->pts, 0, 0, den); frac_init(&st->pts, 0, 0, den);
} }
} }
if (options) {
av_dict_free(options);
*options = tmp;
}
return 0; return 0;
fail: }
av_dict_free(&tmp);
return ret; int avformat_write_header(AVFormatContext *s, AVDictionary **options)
{
int ret = 0;
if (ret = init_muxer(s, options))
return ret;
if (s->oformat->write_header) {
ret = s->oformat->write_header(s);
if (ret < 0)
return ret;
}
if ((ret = init_pts(s) < 0))
return ret;
return 0;
} }
//FIXME merge with compute_pkt_fields //FIXME merge with compute_pkt_fields